Skip to content

[NFC] Don't crash when we see an empty filename for a module. #30099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2020
Merged

[NFC] Don't crash when we see an empty filename for a module. #30099

merged 1 commit into from
Feb 27, 2020

Conversation

varungandhi-apple
Copy link
Contributor

Fixes rdar://problem/59769612.

cc @clackary

@varungandhi-apple
Copy link
Contributor Author

@swift-ci please smoke test

@varungandhi-apple
Copy link
Contributor Author

varungandhi-apple commented Feb 27, 2020 •
edited
Loading

[Sorry the branch name is misleading, it should be empty-module-filename not empty-module-name.]

@varungandhi-apple varungandhi-apple merged commit 2dfd569 into swiftlang:master Feb 27, 2020
@varungandhi-apple varungandhi-apple deleted the vg-disable-crash-on-empty-module-name branch February 27, 2020 20:58
@DougGregor
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor Awaiting requested review from DougGregor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varungandhi-apple @DougGregor