[ASTPrinter] Fix duplicate «mutating» modifiers when printing file interface #30011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
approved these changes
Feb 25, 2020
|
@swift-ci Please smoke test |
This was referenced Mar 3, 2020
|
@slavapestov @brentdax is this ready to go? I don't understand the PrintImplicitAttributes part of this change, but the rest seems good to me. |
AnthonyLatsis
commented
Mar 3, 2020
| @@ -1008,19 +1005,23 @@ void PrintAST::printAttributes(const Decl *D) { | |||
| // clients, or if it inherits superclass convenience initializers, | |||
| // then print those attributes specially. | |||
| if (auto CD = dyn_cast<ClassDecl>(D)) { | |||
| if (Options.PrintImplicitAttrs) { | |||
There was a problem hiding this comment.
@benlangmuir This is all nested inside if (Options.PrintImplicitAttrs) up above, so I just eliminated the unnecessary scope.
|
@benlangmuir I am not sure when we will hear from Slava, but since the change is approved, do you mind merging it for me? This better be fixed for 5.2. |
|
Let's re-test since it's been so long. |
|
@swift-ci Please smoke test |
|
Thanks, Ben! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves SR-12139.
I am still unable to sort out the expected behavior of
PrintImplicitAttributesthough. In particular, the if statement inprintAttributesis narrowing down the set of attributes to print in a strangely selective manner (although printing implicit attributes implies printing more attributes than otherwise).