Skip to content

[SR-12139] [Swift 5.2] 'mutating' printed twice in quick help #54574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johnfairh opened this issue Feb 6, 2020 · 6 comments
Closed

[SR-12139] [Swift 5.2] 'mutating' printed twice in quick help #54574

johnfairh opened this issue Feb 6, 2020 · 6 comments
Assignees
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior.

Comments

@johnfairh
Copy link
Contributor

Previous ID SR-12139
Radar rdar://problem/59302411
Original Reporter @johnfairh
Type Bug
Status Resolved
Resolution Done

Attachment: Download

Environment

Swift 5.2 from Xcode 11.4 beta 1 (11N111s)

Apple Swift version 5.2 (swiftlang-1103.0.22 clang-1103.0.22)

Additional Detail from JIRA
Votes 0
Component/s Source Tooling
Labels Bug
Assignee @AnthonyLatsis
Priority Medium

md5: c5d6f02fa61f62dfe5c10ed4c1db8153

is duplicated by:

  • SR-12527 The mutating keyword is duplicated and displayed.

Issue Description:

'mutating' keyword prints twice in quick-help style ASTPrinter. `--print-ast` is fine.

Affects structs as well as protocols.

Maybe #24277, wild guess on 'mutating' showing up @AnthonyLatsis ?

@AnthonyLatsis
Copy link
Collaborator

Hmm.. @rintaro do you know if Quick Help uses ASTPrinter?

@johnfairh
Copy link
Contributor Author

It does; an easier way to see the problem is via `swift-ide-test`:

; cat Mut.swift 
struct S {
  mutating func f() {}
}
; swift-ide-test --print-swift-file-interface -source-filename=Mut.swift 

internal struct S {

    mutating internal mutating func f()
}

@AnthonyLatsis
Copy link
Collaborator

I see, thanks. It could very well be #​24277, despite the validation tests. I'll take responsibility for this as soon as I can

@beccadax
Copy link
Contributor

@swift-ci create

@AnthonyLatsis
Copy link
Collaborator

#30011

@johnfairh
Copy link
Contributor Author

Thanks for pursuing this!

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior.
Projects
None yet
Development

No branches or pull requests

3 participants