[5.2] SILGen: Fix withoutActuallyEscaping of 'c' closures #29570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They don't have a context and therefore are not consumed. Fixes a failing assert. * Description: The compiler asserts on code that uses withoutActuallyEscaping on a ‘c’ convention closure. * Scope: Compiling source code that uses that combination will assert and fail to compile. In no asserts build the compilation succeeds and generates correct code (i.e the assert failure is inconsequential). The problem existed in previously released version of the compiler. * Testing: A swift regression test was added. * Reviewed: Andrew T Original PR: swiftlang#29569 rdar://59046275
|
@swift-ci Please test |
airspeedswift
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They don't have a context and therefore are not consumed.
Fixes a failing assert.
Description: The compiler asserts on code that uses
withoutActuallyEscaping on a ‘c’ convention closure.
Scope: Compiling source code that uses that combination will assert
and fail to compile. In no asserts build the compilation succeeds and
generates correct code (i.e the assert failure is inconsequential). The
problem existed in previously released version of the compiler.
Testing: A swift regression test was added.
Reviewed: Andrew T
Original PR: #29569
rdar://59046275