[5.2] Turn off speculative devirtualization by default. #29514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a cherrypick of swiftlang#29359 Explanation: Disable speculative devirtualization optimization. The optimization did not give significant performance wins. Disabling it improves code size. Risk: Low. No significant performance hit is expected. Issue: rdar://problem/58778959 Testing: Performance tests and regression tests Reviewer: Erik Eckstein
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci Please nominate |
airspeedswift
approved these changes
Jan 29, 2020
airspeedswift
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherrypick of #29359
Explanation: Disable speculative devirtualization optimization. The
optimization did not give significant performance wins. Disabling it
improves code size.
Risk: Low. No significant performance hit is expected.
Issue: rdar://problem/58778959
Testing: Performance tests and regression tests
Reviewer: Erik Eckstein