[AutoDiff upstream] Add SIL derivative function type calculation. #29396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `SILFunctionType::getAutoDiffDerivativeFunctionType`. It computes the derivative `SILFunctionType` for an "original" `SILFunctionType`, given: - Differentiability parameter indices - Differentiability result index - Derivative function kind - Derivative function generic signature (optional) - Other auxiliary parameters Add doc comments explaining typing rules, preconditions, and other details. Partially resolves TF-1124. Unblocks upstreaming other SIL differentiable programming infrastructure.
rxwei
approved these changes
Jan 23, 2020
|
@swift-ci Please test |
|
@jckarter: would you like to review this PR, or suggest a reviewer? I'm asking you since you seem like a SIL code owner. This PR is part of our effort to upstream differentiable programming. It adds a utility function and should be relatively non-controversial. If there's no activity, I'll merge within a day to unblock progress. Happy to address feedback at any time! |
|
Makes sense to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
SILFunctionType::getAutoDiffDerivativeFunctionType.It computes the derivative
SILFunctionTypefor an "original"SILFunctionType, given:Add doc comments explaining typing rules, preconditions, and other details.
Partially resolves TF-1124.
Unblocks upstreaming other SIL differentiable programming infrastructure.