[Constraint system] Decouple the constraint system from a specific expression #28166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
3 similar comments
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
solve() is a bit too overloaded, so rename the version that does the core "evaluate all of the steps to produce a set of solutions" functionality to solveImpl().
This parameter was unused anyway.
…ostics. We're still using the root expression to find the parent map, but we're not falling back to it indiscriminately. Use the parent of the anchor (or appropriate substitute) instead so we have a better handle on which expression we're diagnosing for.
We're not using it for anything, now.
DougGregor
force-pushed
the
constraint-system-decouple-expr
branch
from
42fd575 to
bc926f7
Compare
xedin
reviewed
Nov 9, 2019
xedin
approved these changes
Nov 9, 2019
|
@swift-ci please smoke test |
xedin
reviewed
Nov 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1/N for refactoring the constraint system to not depend so much on the idea that one constraint system == one expression.