Sema: Print property accessors for non-mutating setter requirements #27896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrose-apple
reviewed
Oct 28, 2019
lib/Sema/TypeCheckProtocol.cpp
Outdated
| @@ -2627,13 +2627,13 @@ printRequirementStub(ValueDecl *Requirement, DeclContext *Adopter, | |||
| Options.FunctionDefinitions = true; | |||
| Options.PrintAccessorBodiesInProtocols = true; | |||
|
|
|||
| bool AdopterIsClass = isa<ClassDecl>(Adopter->getAsDecl()); | |||
There was a problem hiding this comment.
This isn't going to be the right test; the adopter might be an extension of a class. What was wrong with the previous one?
There was a problem hiding this comment.
My bad, thanks. To be honest, the previous one seemed inelegant to me.
AnthonyLatsis
force-pushed
the
proto-stubs-nonmutating-set
branch
from
deb1517 to
5d0db67
Compare
AnthonyLatsis
force-pushed
the
proto-stubs-nonmutating-set
branch
from
5d0db67 to
9b77ae5
Compare
jrose-apple
approved these changes
Oct 28, 2019
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #24277
@jrose-apple