Change comparisons to increase code uniformity in max and min algorithms #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 consistency is always good |
Contributor
|
The goal here is not surface-level uniformity, but getting the semantics we want. Please read the discussion in pull request #137. |
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
Adding documentation to clarify the result of DispatchTime(uptimeNanoseconds: 0)
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
Adding documentation to clarify the result of DispatchTime(uptimeNanoseconds: 0) Signed-off-by: Daniel A. Steffen <[email protected]>
dabelknap
added a commit
to dabelknap/swift
that referenced
this pull request
Jan 24, 2019
Improve the formatter configuration.
kateinoigakukun
added a commit
to kateinoigakukun/swift
that referenced
this pull request
Feb 25, 2020
* [WASM] Update ICU The main change is here swiftwasm/icu4c-wasi@171b2a5 * [WASM] Update to build ICU with latest wasi-sdk * Update ICU to archive with wasi-sdk bin
maldahleh
pushed a commit
to maldahleh/swift
that referenced
this pull request
Oct 26, 2020
Fix Readme Example
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
…-which-we-have-swift-4-hashes Remove Swift 3.x hashes for things that we're already testing with 4.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the current max or min value would be compared and sometimes it would compare the parameter. This changes so that it always compares to the current max or min value, not the parameter. Even though it makes no changes to the functionality of the method, it helps to organize it and create uniformity.