Skip to content

[Parse] Fix crash case in parseStmtForeach #12202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
slavapestov merged 1 commit into from
Oct 1, 2017
Merged

[Parse] Fix crash case in parseStmtForeach #12202

slavapestov merged 1 commit into from
Oct 1, 2017

Conversation

@rintaro
Copy link
Member

@rintaro rintaro commented Oct 1, 2017

Don't treat

for
;

as removed C-style for statement.

@rintaro
Copy link
Member Author

rintaro commented Oct 1, 2017

@swift-ci Please smoke test

@rintaro rintaro force-pushed the crasher-crasher-28843 branch from f8de7c4 to cd3bf03 Compare October 1, 2017 01:36
@rintaro
Copy link
Member Author

rintaro commented Oct 1, 2017

Added test case.
@swift-ci Please smoke test

DougGregor
DougGregor approved these changes Oct 1, 2017
View reviewed changes
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@slavapestov slavapestov merged commit abd8d93 into swiftlang:master Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rintaro @DougGregor @slavapestov