[AST] Fix argument to diagnostic #1016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ha, thanks. Can you try to find a non-fuzzing-based test case and add it to your commit? |
gregomni
force-pushed
the
nil-raw-diagnosis
branch
from
aa8c33d to
4c2a47b
Compare
A simple “%1” to “%0” for a diagnosis with just one arg, along with a test case for it.
gregomni
force-pushed
the
nil-raw-diagnosis
branch
from
4c2a47b to
b4b77fb
Compare
|
@jrose-apple Sure thing! Done and squashed and tests run. |
lattner
added a commit
that referenced
this pull request
Jan 20, 2016
[AST] Fix argument to diagnostic
|
Thanks! |
|
Ah, now that #1013 has been merged we need to update that test too. |
MaxDesiatov
added a commit
to MaxDesiatov/swift
that referenced
this pull request
May 20, 2020
…ndencies Make macOS dependencies script idempotent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple “%1” to “%0” for a diagnosis with just one arg.
This is a fix for the crash here: #1013