-
Notifications
You must be signed in to change notification settings - Fork 108
build: restructure the installation location #971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CC: @etcwilde |
@swift-ci please test |
3a31fcf
to
eb4e0c7
Compare
@swift-ci please test |
eb4e0c7
to
a945726
Compare
@swift-ci please test |
a945726
to
422d8f5
Compare
@swift-ci please test |
422d8f5
to
50ec4a6
Compare
@swift-ci please test |
50ec4a6
to
c1003cd
Compare
@swift-ci please test |
With local testing:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had one question about the CMP0157
policy change I just noticed, but otherwise this is looking good to me now
c1003cd
to
9ac5cd2
Compare
@swift-ci please test |
9ac5cd2
to
e418145
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, feel free to merge!
Clean up some of the module property handling to be more declarative. This reduces the operations that are being done on targets in favour of defaults. Adopt the latest best practices for handling module installation. Introduce the new `SwiftTesting_INSTALL_NESTED_SUBDIR` option to allow installation into platform/architecture subdirectory allowing multi-architecture installations for platforms like Windows and Android. This is currently opt-in and requires a newer toolchain (something within the last ~2w) to detect the defaults. The values can be overridden by the user if desired.
@swift-ci please test |
Clean up some of the module property handling to be more declarative. This reduces the operations that are being done on targets in favour of defaults.
Adopt the latest best practices for handling module installation. Introduce the new
SwiftTesting_INSTALL_NESTED_SUBDIR
option to allow installation into platform/architecture subdirectory allowing multi-architecture installations for platforms like Windows and Android. This is currently opt-in and requires a newer toolchain (something within the last ~2w) to detect the defaults. The values can be overridden by the user if desired.