Add a new _TestDiscovery library/target. #981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR factors out our test discovery logic into a separate module that can be imported and linked to without needing to build all of Swift Syntax and Swift Testing. This allows test library developers to start experimenting with using the new (still experimental) test content section without needing to link to a package copy of Swift Testing.
grynspan
added
enhancement
grynspan
requested review from
stmontgomery,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
grynspan
force-pushed
the
jgrynspan/test-discovery-target
branch
from
efe4a4a to
b7ec1a8
Compare
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
stmontgomery
reviewed
Mar 3, 2025
stmontgomery
reviewed
Mar 3, 2025
stmontgomery
reviewed
Mar 3, 2025
stmontgomery
reviewed
Mar 3, 2025
stmontgomery
reviewed
Mar 3, 2025
stmontgomery
reviewed
Mar 3, 2025
|
@swift-ci test |
compnerd
reviewed
Mar 3, 2025
| target_compile_options(_TestDiscovery PRIVATE | ||
| -enable-library-evolution | ||
| -emit-module-interface -emit-module-interface-path $<TARGET_PROPERTY:_TestDiscovery,Swift_MODULE_DIRECTORY>/_TestDiscovery.swiftinterface) | ||
| set(CMAKE_STATIC_LIBRARY_PREFIX_Swift "lib") |
There was a problem hiding this comment.
You should hoist this to the top level CMakeLists.txt
There was a problem hiding this comment.
I don't think it affects anything else right now—do you feel strongly about it?
There was a problem hiding this comment.
I think its best to keep this at the top level - it would be very confusing and annoying to someone not aware of it and adding another library.
There was a problem hiding this comment.
Will do it in a follow-up PR just because this one's already passed toolchain builds and I'd like to not tempt fate.
|
@swift-ci test |
|
@swift-ci test |
stmontgomery
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR factors out our test discovery logic into a separate module that can be imported and linked to without needing to build all of Swift Syntax and Swift Testing.
This allows test library developers to start experimenting with using the new (still experimental) test content section without needing to link to a package copy of Swift Testing.
Resolves rdar://145694068.
Checklist: