Emit ABIv0 JSON objects for tests when listing them. #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
added
enhancement
grynspan
force-pushed
the
jgrynspan/506-json-records-for-listing-tests
branch
from
b7d7088 to
6bbdb36
Compare
grynspan
force-pushed
the
jgrynspan/506-json-records-for-listing-tests
branch
2 times, most recently
from
2faa04c to
c4da69f
Compare
This PR changes the behavior of `swift test list` and its various synonyms to allow reporting the list of tests via the ABI-stable JSON mechanism described in #479. As it is not currently possible to directly call `swift test list --experimental-event-stream-output ... --experimental-event-stream-version 0`, it's a bit hard to test this code. However, it is possible to opt into this mode using `--experimental-configuration-path` and passing a path to a JSON file that includes `"listTests": true` (as noted by @allevato.) Resolves #506. Resolves rdar://130627856.
grynspan
force-pushed
the
jgrynspan/506-json-records-for-listing-tests
branch
from
c4da69f to
74421ee
Compare
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
briancroom
reviewed
Jul 12, 2024
briancroom
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of
swift test listand its various synonyms to allow reporting the list of tests via the ABI-stable JSON mechanism described in #479.As it is not currently possible to directly call
swift test list --event-stream-output-path ... --event-stream-version 0, it's a bit hard to test this code. However, it is possible to opt into this mode using--configuration-pathand passing a path to a JSON file that includes"listTests": true(as noted by @allevato.) Support for these arguments withswift test listis tracked by swiftlang/swift-package-manager#7768.Resolves #506.
Resolves rdar://130627856.
Checklist: