Promote exit tests to API #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
added
tools integration
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
grynspan
force-pushed
the
jgrynspan/exit-tests-proposal
branch
from
fe21f14 to
988ddfe
Compare
grynspan
force-pushed
the
jgrynspan/exit-tests-proposal
branch
from
988ddfe to
697123a
Compare
grynspan
force-pushed
the
jgrynspan/exit-tests-proposal
branch
3 times, most recently
from
19f37c3 to
4825821
Compare
grynspan
force-pushed
the
jgrynspan/exit-tests-proposal
branch
2 times, most recently
from
feb425b to
e84b014
Compare
grynspan
force-pushed
the
jgrynspan/exit-tests-proposal
branch
2 times, most recently
from
6f0e7f0 to
875b870
Compare
grynspan
force-pushed
the
jgrynspan/exit-tests-proposal
branch
from
875b870 to
4365611
Compare
grynspan
force-pushed
the
jgrynspan/exit-tests-proposal
branch
from
4365611 to
7d25e07
Compare
|
Rebased. |
grynspan
force-pushed
the
jgrynspan/exit-tests-proposal
branch
from
23985d8 to
11b772d
Compare
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci please test |
stmontgomery
approved these changes
Apr 30, 2025
grynspan
commented
Apr 30, 2025
|
@swift-ci please test |
|
The macOS CI failure is expected to be resolved by swiftlang/swift#80830, but the release of a new main snapshot toolchain is currently blocked for unrelated reasons. |
2 tasks
stmontgomery
added a commit
that referenced
this pull request
May 7, 2025
…ability when building w/legacy driver (#1106) This works around a Swift compiler bug which causes a failure validating the generated .swiftinterface of the `Testing` module due to it having macro declarations with `#if`-conditionalized `@available(...)` attributes _before_ any other `@`-attributes. The PR which recently landed to enable the Exit Tests feature (#324) revealed this compiler bug — specifically, that PR removed `@_spi` attributes which until then _preceded_ `#if SWT_NO_EXIT_TESTS`. The workaround is to move other attributes on the affected macro declarations up before the `#if`. The compiler bug is being fixed in swiftlang/swift#81346. It only appears to happen when building with the legacy driver, and Android uses that driver still. An example CI failure log can be found here: > https://github.com/thebrowsercompany/swift-build/actions/runs/14823859186/job/41615678071#step:32:72 ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR promotes exit tests to API, pending approval of the proposal at swiftlang/swift-evolution#2718.
View the full proposal here.
Checklist: