Fix newline detection logic for carriage return line feeds #2106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`\r\n` is considered a single character in Unicode and we thus need to check for it specifically and checking for `\n` on its own is not sufficient.
…s` (swiftlang#2100)" This reverts commit acc0320. rdar://114406758
|
@swift-ci Please test |
bnbarham
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\r\nis considered a single character in Unicode and we thus need to check for it specifically and checking for\non its own is not sufficient.Also reverts #2100 since the tests are passing again now.
rdar://114406758