Update code-gen tool for lowercase child name consistency #1908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes to the code-gen tool to ensure consistency with already generated code. This is a preparatory step before we start changing the names of all child elements to be lowercase - #1901.
In the #1901 issue description @ahoppen mention that
After research, I've learned that we're using the
name
property ofChild
as uppercased in the following contexts:enum accessorSpecifierOptions: TokenSpecSet
and them as types e.g.:ElseBody
forIfExprSyntax
,I guess now with this knowledge the question is: should we still lowercased values of the
name
property of eachChild
?If we will decide to continue working on this issue here is the script I'm gonna use to change names: