Skip to content

Change name property of Child in CodeGeneration to be lowercase #1901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ahoppen opened this issue Jul 13, 2023 · 3 comments · Fixed by #2055
Closed

Change name property of Child in CodeGeneration to be lowercase #1901

ahoppen opened this issue Jul 13, 2023 · 3 comments · Fixed by #2055
Assignees
@Matejkob
Labels
good first issue Good for newcomers

Comments

@ahoppen
Copy link
Member

ahoppen commented Jul 13, 2023

It’s a little counter-intuitive that the name property of Child needs to be uppercase because AFAICT we are always using it as lowercase. Change the argument to be lowercase. The generated code should not change.
@ahoppen ahoppen added the good first issue Good for newcomers label Jul 13, 2023
@ahoppen
Copy link
Member Author

ahoppen commented Jul 13, 2023

Tracked in Apple’s issue tracker as rdar://112178612

@Matejkob
Copy link
Contributor

I love this idea! May I try to develop it?

@ahoppen
Copy link
Member Author

ahoppen commented Jul 13, 2023

Definitely!

@Matejkob Matejkob mentioned this issue Jul 14, 2023
Closed
This was referenced Aug 7, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Matejkob Matejkob

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@ahoppen @Matejkob