[5.9][Macros] Unify PluginMessages.swift #1866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiler use PluginMessages.swift in swift-syntax consistently. (cherry picked from commit 2bdbaf5)
|
swiftlang/swift#67038 |
|
swiftlang/swift#67038 |
DougGregor
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1865 into release/5.9
swiftchange swiftlang/swift#67038ASTGeninswiftrepo andSwiftCompilerPluginMessageHandlinginswift-syntaxused to have separatePluginMessages.swift. When we change the executable plugin IPC message format, we needed to change both files exactly the same way. That was confusing and there was no benefit of having separate files in 2 repositories. Instead, expose that message types fromswift-syntaxand use it fromswiftrepo. So that we have the single source of truth inswift-syntaxASTGennowimportthe module in swift-syntax repo which is already built/installed in the toolchain