assertMacroExpansion should assert if there are errors #1758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
rintaro
approved these changes
Jun 10, 2023
kimdv
approved these changes
Jun 10, 2023
ahoppen
reviewed
Jun 11, 2023
| let expandedSourceFile = origSourceFile.expand(macros: macros, in: context) | ||
| let formattedSourceFile = expandedSourceFile.formatted(using: BasicFormat(indentationWidth: indentationWidth)) | ||
|
|
||
| XCTAssertFalse(expandedSourceFile.hasError, "Expanded source should not contain any syntax errors") |
There was a problem hiding this comment.
What do you think about running ParseDiagnsoticGenerator to actually show the syntax errors?
There was a problem hiding this comment.
Sounds reasonable. I also considered showing the debug description but that seemed a bit much. This seems like a better idea.
There was a problem hiding this comment.
I added this but IMO they still don't make much sense without the syntax tree. So I added that in as well.
bnbarham
force-pushed
the
assert-on-macro-errors
branch
2 times, most recently
from
e5ff9c1 to
41c0078
Compare
|
@swift-ci please test |
ahoppen
approved these changes
Jun 12, 2023
Invalid macro expansions should generate an assertion in `assertMacroExpansion` rather than being ignored.
bnbarham
force-pushed
the
assert-on-macro-errors
branch
from
41c0078 to
ea2d7e4
Compare
|
@swift-ci please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalid macro expansions should generate an assertion in
assertMacroExpansionrather than being ignored.