If no explicit highlight range was given, highlight the node the diagnostic is anchored at instead of highlighting nothing #1441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nostic is anchored at instead of highlighting nothing rdar://104113111
|
@swift-ci Please smoke test |
kimdv
approved these changes
Mar 25, 2023
|
@swift-ci Please test |
rintaro
approved these changes
Mar 27, 2023
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
Mar 31, 2023
If no explicit highlight range was given, highlight the node the diagnostic is anchored at instead of highlighting nothing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially for IDEs we should always report a highlight range whenever possible because it looks nicer if a token can be underlined instead of just underlining the character at which the diagnostic is anchored, which is what many IDEs default to.
rdar://104113111