Don’t fatalError when expressing syntax nodes by string literals #1290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/string-interpolation-no-fatalerror
branch
from
4ad0a0d to
82e5258
Compare
|
@swift-ci Please test |
kimdv
approved these changes
Jan 28, 2023
|
Whoops, pretend my #1291 comments were here 😅 |
bnbarham
approved these changes
Jan 31, 2023
We should not crash the process if the source code that you use to create a syntax node using string interpolation is invalid. Instead we should:
- Not check for errors in the normal string interpolation case and just return a syntax tree that has the `hasError` flag set when there are syntax errors
- In either SwiftSyntaxBuilder offer `init(validating node: Self) throws` that check that `node` has no sytnax errors and throws otherwise. This allows us write e.g. `try wDeclSyntax(validating: "struct Foo {}")` to create a `DeclSyntax` that’s guaranteed to not have any syntax errors
rdar://104423126
ahoppen
force-pushed
the
ahoppen/string-interpolation-no-fatalerror
branch
from
82e5258 to
21e5eaa
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not crash the process if the source code that you use to create a syntax node using string interpolation is invalid. Instead we should:
hasErrorflag set when there are syntax errorsinit(validating node: Self) throwsthat check thatnodehas no sytnax errors and throws otherwise. This allows us write e.g.try wDeclSyntax(validating: "struct Foo {}")to create aDeclSyntaxthat’s guaranteed to not have any syntax errors.I’m not sure yet whether CodeGeneration should use
init(validating:)withtry!sprayed all over the place or have something likeinit(checking:)thatfatalErrors if the syntax is not valid.rdar://104423126