[Bootstrap] Add an extra argument to set a library path. #9118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During Swift PR testing, we run the SwiftPM tests. Unfortunately, the SwiftPM tests always try to link with the system version of the Swift runtime libraries. This would be fine, except that Swift Testing has been built against the *new* runtimes and as a result has ended up referencing symbols from them that might not be present in the system runtime libraries. To fix this, add an extra argument to allow us to add to the `DYLD_LIBRARY_PATH` setting SwiftPM uses to run its tests. rdar://160273124
|
Testing this solution on my failing PR. |
Fixed a typo in the script. rdar://160273124
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During Swift PR testing, we run the SwiftPM tests. Unfortunately, the SwiftPM tests always try to link with the system version of the Swift runtime libraries. This would be fine, except that Swift Testing has been built against the new runtimes and as a result has ended up referencing symbols from them that might not be present in the system runtime libraries.
To fix this, add an extra argument to allow us to add to the
DYLD_LIBRARY_PATHsetting SwiftPM uses to run its tests.rdar://160273124