-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Implement SwiftFixIt — a library for deserializing diagnostics and applying fix-its #8585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please test |
@swift-ci please test |
@AnthonyLatsis looks like this is still crashing due to ownership issues:
|
…plying fix-its For now, this API accepts a collection of `.dia` files, deserializes them, and applies fix-its in place. Eventually, it is expected to serve the upcoming `swift fixit` and `swift migrate` subcommands and support various filtering options, as well as a stateful, interactive workflow similar to `git add --patch`.
37284aa
to
9050542
Compare
@swift-ci please test |
@swift-ci please test Windows platform |
This PR broke the Windows distribution (CC: @dschaefer2) as it introduced a new library that is not being shipped. CC: @shahmishal |
Did these changes not help? |
@AnthonyLatsis no, those would not help because the new DLL needs to be shipped. swiftlang/swift-installer-scripts#420 is the necessary change to ship a new DLL. |
I see. @xedin was switching to a dynamic library intended to fix something else? |
That's what the the rest of the targets have i.e. Build and SourceControl. |
Motivation:
This is part of the migration tooling initiative for Swift features.
Modifications:
For now, this API accepts a collection of
.dia
files, deserializes them, and applies fix-its in place. Eventually, it is expected to serve the upcomingswift fixit
andswift migrate
subcommands and support various filtering options, as well as a stateful, interactive workflow similar togit add --patch
.