Implement SwiftFixIt — a library for deserializing diagnostics and applying fix-its #8585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
xedin
approved these changes
Apr 30, 2025
|
@swift-ci please test |
|
@swift-ci please test |
|
@AnthonyLatsis looks like this is still crashing due to ownership issues: |
…plying fix-its For now, this API accepts a collection of `.dia` files, deserializes them, and applies fix-its in place. Eventually, it is expected to serve the upcoming `swift fixit` and `swift migrate` subcommands and support various filtering options, as well as a stateful, interactive workflow similar to `git add --patch`.
AnthonyLatsis
force-pushed
the
danaus-plexippus-7
branch
from
37284aa to
9050542
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
This PR broke the Windows distribution (CC: @dschaefer2) as it introduced a new library that is not being shipped. CC: @shahmishal |
|
Did these changes not help? |
|
@AnthonyLatsis no, those would not help because the new DLL needs to be shipped. swiftlang/swift-installer-scripts#420 is the necessary change to ship a new DLL. |
|
I see. @xedin was switching to a dynamic library intended to fix something else? |
|
That's what the the rest of the targets have i.e. Build and SourceControl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This is part of the migration tooling initiative for Swift features.
Modifications:
For now, this API accepts a collection of
.diafiles, deserializes them, and applies fix-its in place. Eventually, it is expected to serve the upcomingswift fixitandswift migratesubcommands and support various filtering options, as well as a stateful, interactive workflow similar togit add --patch.