WiX: package SwiftFixIt.dll on Windows #420
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of SPM, introduced in swiftlang/swift-package-manager3#8585. The newly minted dependency causes `swift build` to fail as it is missing the library in the installation (caught by CI at https://github.com/thebrowsercompany/swift-build/actions/runs/14890246041).
xedin
approved these changes
May 12, 2025
etcwilde
approved these changes
May 12, 2025
|
SwiftPM PR - swiftlang/swift-package-manager#8661 |
|
@xedin how long would that take? Windows hasn't had a toolchain bump since 4/3, and I'd rather get this in to unblock that. |
|
@compnerd a couple of hours for CI to run but if that's pressing go ahead an merge, we can always revert later. |
|
I'll wait until later today - if we get the conversion in, that is good. Merging this and that would then break the build as this will fail to build the installer once that library disappears |
|
I'll keep an eye on the status of that PR and ping you. |
|
Merged the SPM change, so going to close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of SPM, introduced in
swiftlang/swift-package-manager#8585. The newly minted dependency causes
swift buildto fail as it is missing the library in the installation (caught by CI athttps://github.com/thebrowsercompany/swift-build/actions/runs/14890246041).