Skip to content

Tests: Enabled SourceControlTests on Windows #8453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

Tests: Enabled SourceControlTests on Windows #8453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 0 additions & 34 deletions Tests/SourceControlTests/GitRepositoryTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,6 @@ class GitRepositoryTests: XCTestCase {

/// Check hash validation.
func testGitRepositoryHash() throws {
try skipOnWindowsAsTestCurrentlyFails(because: """
Test failed with: 0 [main] sh (9736) C:\\Program Files\\Git\\usr\\bin\\sh.exe: *** fatal error - add_item ("\\??\\C:\\Program Files\\Git", "/", ...) failed, errno 1
""")

let validHash = "0123456789012345678901234567890123456789"
XCTAssertNotEqual(GitRepository.Hash(validHash), nil)

Expand Down Expand Up @@ -190,10 +186,6 @@ class GitRepositoryTests: XCTestCase {
}

func testSubmoduleRead() throws {
try skipOnWindowsAsTestCurrentlyFails(because: """
Test failed with: 0 [main] sh (9736) C:\\Program Files\\Git\\usr\\bin\\sh.exe: *** fatal error - add_item ("\\??\\C:\\Program Files\\Git", "/", ...) failed, errno 1
""")

try testWithTemporaryDirectory { path in
let testRepoPath = path.appending("test-repo")
try makeDirectories(testRepoPath)
Expand Down Expand Up @@ -305,10 +297,6 @@ class GitRepositoryTests: XCTestCase {

/// Test the handling of local checkouts.
func testCheckouts() throws {
try skipOnWindowsAsTestCurrentlyFails(because: """
Test failed with: 0 [main] sh (9736) C:\\Program Files\\Git\\usr\\bin\\sh.exe: *** fatal error - add_item ("\\??\\C:\\Program Files\\Git", "/", ...) failed, errno 1
""")

try testWithTemporaryDirectory { path in
// Create a test repository.
let testRepoPath = path.appending("test-repo")
Expand Down Expand Up @@ -355,10 +343,6 @@ class GitRepositoryTests: XCTestCase {
}

func testFetch() throws {
try skipOnWindowsAsTestCurrentlyFails(because: """
Test failed with: 0 [main] sh (9736) C:\\Program Files\\Git\\usr\\bin\\sh.exe: *** fatal error - add_item ("\\??\\C:\\Program Files\\Git", "/", ...) failed, errno 1
""")

try testWithTemporaryDirectory { path in
// Create a repo.
let testRepoPath = path.appending("test-repo")
Expand Down Expand Up @@ -398,10 +382,6 @@ class GitRepositoryTests: XCTestCase {
}

func testHasUnpushedCommits() throws {
try skipOnWindowsAsTestCurrentlyFails(because: """
Test failed with: 0 [main] sh (9736) C:\\Program Files\\Git\\usr\\bin\\sh.exe: *** fatal error - add_item ("\\??\\C:\\Program Files\\Git", "/", ...) failed, errno 1
""")

try testWithTemporaryDirectory { path in
// Create a repo.
let testRepoPath = path.appending("test-repo")
Expand Down Expand Up @@ -438,10 +418,6 @@ class GitRepositoryTests: XCTestCase {
}

func testSetRemote() throws {
try skipOnWindowsAsTestCurrentlyFails(because: """
Test failed with: 0 [main] sh (9736) C:\\Program Files\\Git\\usr\\bin\\sh.exe: *** fatal error - add_item ("\\??\\C:\\Program Files\\Git", "/", ...) failed, errno 1
""")

try testWithTemporaryDirectory { path in
// Create a repo.
let testRepoPath = path.appending("test-repo")
Expand Down Expand Up @@ -554,10 +530,6 @@ class GitRepositoryTests: XCTestCase {
}

func testCheckoutRevision() throws {
try skipOnWindowsAsTestCurrentlyFails(because: """
Test failed with: 0 [main] sh (9736) C:\\Program Files\\Git\\usr\\bin\\sh.exe: *** fatal error - add_item ("\\??\\C:\\Program Files\\Git", "/", ...) failed, errno 1
""")

try testWithTemporaryDirectory { path in
// Create a repo.
let testRepoPath = path.appending("test-repo")
Expand Down Expand Up @@ -690,8 +662,6 @@ class GitRepositoryTests: XCTestCase {
}

func testAlternativeObjectStoreValidation() throws {
try skipOnWindowsAsTestCurrentlyFails(because: "test might hang in CI")

try testWithTemporaryDirectory { path in
// Create a repo.
let testRepoPath = path.appending("test-repo")
Expand Down Expand Up @@ -762,10 +732,6 @@ class GitRepositoryTests: XCTestCase {
}

func testMissingDefaultBranch() throws {
try skipOnWindowsAsTestCurrentlyFails(because: """
Test failed with: 0 [main] sh (9736) C:\\Program Files\\Git\\usr\\bin\\sh.exe: *** fatal error - add_item ("\\??\\C:\\Program Files\\Git", "/", ...) failed, errno 1
""")

try testWithTemporaryDirectory { path in
// Create a repository.
let testRepoPath = path.appending("test-repo")
Expand Down
4 changes: 0 additions & 4 deletions Tests/SourceControlTests/RepositoryManagerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@ import XCTest

final class RepositoryManagerTests: XCTestCase {
func testBasics() async throws {
try skipOnWindowsAsTestCurrentlyFails(because: """
Test failed with: 0 [main] sh (9736) C:\\Program Files\\Git\\usr\\bin\\sh.exe: *** fatal error - add_item ("\\??\\C:\\Program Files\\Git", "/", ...) failed, errno 1
""")

let fs = localFileSystem
let observability = ObservabilitySystem.makeForTesting()

Expand Down