Remove @MainActor from XCTest glue.
#7967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes `@MainActor` and adds `nonisolated(unsafe)` to suppress concurrency diagnostics in the XCTest glue code generated when using corelibs-xctest.
grynspan
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
|
@swift-ci test |
DougGregor
approved these changes
Sep 17, 2024
xedin
approved these changes
Sep 17, 2024
dschaefer2
approved these changes
Sep 17, 2024
|
@swift-ci please test windows |
jakepetroules
approved these changes
Sep 17, 2024
|
@swift-ci test Windows |
|
Test failure on Windows, thought it seems to be in the foundation tests... |
|
@swift-ci test windows |
|
|
|
@swift-ci test Windows |
|
@swift-ci test Windows |
grynspan
added a commit
to swiftlang/swift-corelibs-foundation
that referenced
this pull request
Sep 24, 2024
SPM and swift-corelibs-xctest do not support main-actor-isolated tests unless they are marked `async` because the compilation stage that finds tests is not actor-aware. This test is preventing us from merging swiftlang/swift-package-manager#7967.
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
grynspan
deleted the
jgrynspan/remove-main-actor-isolation-from-xctest-glue
branch
grynspan
added a commit
that referenced
this pull request
Sep 27, 2024
**Explanation:** Remove `@MainActor` annotations from corelibs-xctest glue functions that are no longer needed. **Scope:** corelibs-xctest glue code **Issue:** [N/A](rdar://130066460) **Original PR:** #7967 **Risk:** Unknown **Testing:** Existing CI jobs **Reviewer:** @bnbarham @briancroom @DougGregor @shahmishal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
@MainActorand addsnonisolated(unsafe)to suppress concurrency diagnostics in the XCTest glue code generated when using corelibs-xctest.See also #7960.