improve identity handling #3308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
tomerd
force-pushed
the
tests/identity
branch
from
0dff969 to
716da29
Compare
motivation: package identity is critical to SwiftPM ability to dedup package reliably changes: * use package identity instead of manifest name to flatten the dependencies list * add more test for duplicate identity permutations across identity derived from URL and manifest name
tomerd
force-pushed
the
tests/identity
branch
from
716da29 to
3551616
Compare
|
@swift-ci please smoke test |
tomerd
added
the
ready
abertelrud
reviewed
Feb 25, 2021
| } | ||
| } | ||
| allManifests = flattenedManifests.values.sorted(by: { $0.manifest.name < $1.manifest.name }) | ||
| allManifests = flattenedManifests.values.sorted(by: { identityResolver.resolveIdentity(for: $0.manifest.packageLocation) < identityResolver.resolveIdentity(for: $1.manifest.packageLocation) }) |
There was a problem hiding this comment.
How expensive is the identity resolution (in theory, once it's complete, regardless of the current implementation)? Should it be cached so that it isn't recomputed inside the comparison closure?
There was a problem hiding this comment.
good point, eventually it will be cached by the resolver itself.
neonichu
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: package identity is critical to SwiftPM ability to dedup package reliably
changes: