Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions Package.swift
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// swift-tools-version:5.7
// swift-tools-version:6.2
/*
This source file is part of the Swift.org open source project

Expand All @@ -14,14 +14,6 @@ import class Foundation.ProcessInfo

let cmarkPackageName = ProcessInfo.processInfo.environment["SWIFTCI_USE_LOCAL_DEPS"] == nil ? "swift-cmark" : "cmark"

// On non-Windows, do not include unsafe flags so SwiftPM allows tagged dependency usage.
var markdownSwiftSettings: [SwiftSetting] = []
#if os(Windows)
markdownSwiftSettings.append(
.unsafeFlags(["-Xcc", "-DCMARK_GFM_STATIC_DEFINE"], .when(platforms: [.windows]))
)
#endif

let package = Package(
name: "swift-markdown",
products: [
Expand All @@ -40,14 +32,15 @@ let package = Package(
exclude: [
"CMakeLists.txt"
],
swiftSettings: markdownSwiftSettings
swiftSettings: [.unsafeFlags(["-Xcc", "-DCMARK_GFM_STATIC_DEFINE"], .when(platforms: [.windows]))]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should all platforms have this flag? What does it do for the platforms that didn't need it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more of a question for @compnerd than me. I think there's a difference between how packages are linked on Windows and elsewhere that requires that we specify static linkage for Windows when building toolchains.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies. I realize now that my question sounded very different from what I meant to ask.

What I meant was: is there any impact on the other platforms of always specifying this but with a when: .windows condition compared to only adding it inside a #if check, like it was before?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On non-Windows platforms, it normally wouldn't have any impact. However, if you were to build with -fvisibility-default=hidden it would internalise the symbols, preventing them from participating in dynamic linking.

Copy link
Contributor Author

@QuietMisdreavus QuietMisdreavus Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-ronnqvist The syntactic difference between .when(platforms: [.windows]) and #if os(Windows) is that the latter restricts the flag to building from a Windows host, but the former restricts the flag to building for a Windows target. Switching it back to the .when form allows us to cross-compile Swift-Markdown for Windows from other hosts (which is important for toolchain builds) with correct linkage.

),
.testTarget(
name: "MarkdownTests",
dependencies: ["Markdown"],
resources: [.process("Visitors/Everything.md")]),
.target(name: "CAtomic"),
]
],
swiftLanguageModes: [.v5]
)

// If the `SWIFTCI_USE_LOCAL_DEPS` environment variable is set,
Expand Down
64 changes: 64 additions & 0 deletions [email protected]
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
// swift-tools-version:5.7
/*
This source file is part of the Swift.org open source project

Copyright (c) 2021-2023 Apple Inc. and the Swift project authors
Licensed under Apache License v2.0 with Runtime Library Exception

See https://swift.org/LICENSE.txt for license information
See https://swift.org/CONTRIBUTORS.txt for Swift project authors
*/

import PackageDescription
import class Foundation.ProcessInfo

let cmarkPackageName = ProcessInfo.processInfo.environment["SWIFTCI_USE_LOCAL_DEPS"] == nil ? "swift-cmark" : "cmark"

let package = Package(
name: "swift-markdown",
products: [
.library(
name: "Markdown",
targets: ["Markdown"]),
],
targets: [
.target(
name: "Markdown",
dependencies: [
"CAtomic",
.product(name: "cmark-gfm", package: cmarkPackageName),
.product(name: "cmark-gfm-extensions", package: cmarkPackageName),
],
exclude: [
"CMakeLists.txt"
]
),
.testTarget(
name: "MarkdownTests",
dependencies: ["Markdown"],
resources: [.process("Visitors/Everything.md")]),
.target(name: "CAtomic"),
]
)

// If the `SWIFTCI_USE_LOCAL_DEPS` environment variable is set,
// we're building in the Swift.org CI system alongside other projects in the Swift toolchain and
// we can depend on local versions of our dependencies instead of fetching them remotely.
if ProcessInfo.processInfo.environment["SWIFTCI_USE_LOCAL_DEPS"] == nil {
// Building standalone, so fetch all dependencies remotely.
package.dependencies += [
.package(url: "https://github.com/swiftlang/swift-cmark.git", branch: "gfm"),
]

// SwiftPM command plugins are only supported by Swift version 5.6 and later.
#if swift(>=5.6)
package.dependencies += [
.package(url: "https://github.com/apple/swift-docc-plugin", from: "1.1.0"),
]
#endif
} else {
// Building in the Swift.org CI system, so rely on local versions of dependencies.
package.dependencies += [
.package(path: "../cmark"),
]
}