Skip to content

[6.1][test-sourcekit-lsp] Use communicate to wait for subprocess to exit #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2025
Merged

[6.1][test-sourcekit-lsp] Use communicate to wait for subprocess to exit #154

merged 1 commit into from
Feb 21, 2025

Conversation

bnbarham
Copy link
Contributor

@bnbarham bnbarham commented Feb 21, 2025 •
edited
Loading

@ahoppen @bnbarham
[test-sourcekit-lsp] Use communicate to wait for subprocess to exit
306595c 
https://docs.python.org/3/library/subprocess.html#subprocess.Popen.wait says that `wait` can deadlock if the process use pipes (which we do) and if it generates too much output.

Might fix rdar://140425949 but I’m entirely certain because that radar looks like a crash in LLVM, which I don’t fully understand.

(cherry picked from commit aa5313e)
@bnbarham bnbarham requested a review from ahoppen February 21, 2025 19:57
@bnbarham bnbarham merged commit 54d6672 into swiftlang:release/6.1 Feb 21, 2025
@bnbarham bnbarham deleted the 6.1-wait-for-exit branch February 21, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahmishal shahmishal shahmishal approved these changes

@ahoppen ahoppen Awaiting requested review from ahoppen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bnbarham @shahmishal @ahoppen