Windows: add property to verbose log when signing #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speednoisemovement
requested review from
compnerd,
etcwilde and
shahmishal
as code owners
Steelskin
approved these changes
Nov 3, 2025
compnerd
requested changes
Nov 3, 2025
speednoisemovement
changed the title
compnerd
approved these changes
Nov 4, 2025
|
Running a smoke test at https://ci-external.swift.org/job/swift-PR-build-toolchain-windows/6220/. Once that passes we should be good to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeing flaky failures on CI from trusted signing. When I saw this locally, adding logging "fixed" it (suggesting a race condition). This change adds a property that lets us turn it on, both to see if it's sufficient and to learn something if it's not.