Skip to content

WiX: a collection of small clean up to the packaging rules #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 22, 2025

Conversation

compnerd
Copy link
Member

Re-sort (lexicographically) the components, remove unnecessary disk attributes, and some minor component renaming to match the general naming. This should ease the migration between the legacy and experimental SDKs.

The disk ID can be tracked on the directory as the apinotes are platform
agnostic.
Adjust the packaging to be sorted lexicographically.
Use `ExperimentalBlocksRuntime` to match better with the other
components. This is ultimately going to be shared across the shared and
static variants of the SDK.
Use `ExperimentalDispatch` to match better with the other
components. This is ultimately going to be shared across the shared and
static variants of the SDK.
Use `LegacySwiftRuntimeMirror` to match better with the other
components.
Rename `lib_FoundationCShims` and `lib_FoundationUnicode` to an
`Experimental` prefix without `lib`. This component is shared across
static and dynamic portions of the new SDK.
@compnerd
Copy link
Member Author

Copy link
Member

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. While we're putting header content on disk 5, should we also move the shims and lib/swift/windows to disk 5?

@compnerd compnerd merged commit dac5ba0 into swiftlang:main Aug 22, 2025
@compnerd compnerd deleted the cleanup branch August 22, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants