Skip to content

Rename CalendarBenchmarks to InternationalizationBenchmarks #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2024
Merged

Rename CalendarBenchmarks to InternationalizationBenchmarks #943

merged 1 commit into from
Sep 25, 2024

Conversation

fabianfett
Copy link
Contributor

Motivation

The Benchmarks package currently fails to resolve. It errors because it can't find Benchmarks/Calendar:

Showing All Issues
invalid custom path 'Benchmarks/Calendar' for target 'CalendarBenchmarks'

Change

  • Rename Benchmarks/Calendar to Benchmarks/Internationalization
  • Rename target CalendarBenchmarks to InternationalizationBenchmarks

Result

Benchmarks run again.

@parkera parkera requested a review from itingliu September 25, 2024 09:22
@parkera
Copy link
Contributor

parkera commented Sep 25, 2024

@swift-ci test

itingliu
itingliu approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@itingliu itingliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@parkera
Copy link
Contributor

parkera commented Sep 25, 2024

What’s with the windows failure?

@itingliu
Copy link
Contributor

Windows failure looks like network issue?

error: RPC failed; curl 56 Recv failure: Connection was reset
    error: 4922 bytes of body are still expected
    fetch-pack: unexpected disconnect while reading sideband packet
    fatal: early EOF
    fatal: fetch-pack: invalid index-pack output

@itingliu
Copy link
Contributor

@swift-ci please test windows

@itingliu itingliu merged commit 258bfb1 into swiftlang:main Sep 25, 2024
3 checks passed
cthielen pushed a commit to cthielen/swift-foundation that referenced this pull request Nov 8, 2024
@fabianfett @cthielen
Rename CalendarBenchmarks to InternationalizationBenchmarks (swif…
420b7ee 
…tlang#943)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itingliu itingliu itingliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabianfett @parkera @itingliu