Follow up for #1198: Fix test for FOUNDATION_FRAMEWORK #1261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`TestSupport` already defines a typealias for `Expression` as `public typealias Expression = Foundation.Expression`. Therefore the top level typealias `private typealias Expression = URL.Template.Expression` caused an error when `TestSupport` is imported. Move the typealias declaration to inside the test suite.
|
@swift-ci please test |
jmschonfeld
approved these changes
Apr 21, 2025
jrflat
approved these changes
Apr 22, 2025
itingliu
added a commit
to itingliu/swift-foundation
that referenced
this pull request
Apr 22, 2025
…RAMEWORK (swiftlang#1261)" This reverts commit 8d63523.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestSupportalready defines a typealias forExpressionaspublic typealias Expression = Foundation.Expression. Therefore the top level typealiasprivate typealias Expression = URL.Template.Expressioncaused an error whenTestSupportis imported.Move the typealias declaration to inside the test suite.