Fix Windows .alwaysMapped deallocator #1147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
This does match the documentation at https://developer.apple.com/documentation/foundation/data
|
@swift-ci please test Linux platform |
|
@swift-ci please test Windows platform |
|
Please cherry-pick this over to release/6.1 |
z2oh
added a commit
to z2oh/swift-foundation
that referenced
this pull request
Jan 29, 2025
(cherry picked from commit 281db8e)
|
Cherry-pick to release/6.1: #1148 |
compnerd
pushed a commit
that referenced
this pull request
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom deallocator is passed a pointer to the allocated buffer, not the underlying handle. The call to
CloseHandlehere was failing withERROR_INVALID_HANDLE, but by changing the callback parameter to shadowpDatainstead ofhMapping(and updating the call toUnmapViewOfFile), the call toCloseHandlenow runs on the expected capturedhMappinghandle.cc @compnerd