NSRange to Range<AttributedString.Index> conversion should be relative to sliced boundaries #1050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d be relative to sliced boundaries
|
@swift-ci please test |
kperryua
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting an
NSRangeto aRange<AttributedString.Index>via our API, the conversion currently does not take the providedAttributedStringProtocol'sstartIndex/endIndexinto account. This means that theNSRange's location is considered relative to the base's start for anAttributedSubstringrather than the substring's start, leading to conversion failing because theNSRangeis often considered beyond the bounds of the slice.This updates the conversion to operate on a slice of the underlying
BigStringso that the range calculation is performed from the slice'sstartIndexrather than the base'sstartIndex.