Calendar.RecurrenceRule: Only match weekday components when filtering by weekday #1020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
hristost
force-pushed
the
hs/recurrence-rule-fix-weekday-filter
branch
from
345972a to
006910c
Compare
|
@swift-ci please test |
… by weekday When filtering by weekdays, we match the dates against a set of date components. These components happened to contain the hour, minute and second components from the anchor date, so filtering would undo previous expansions by hour, minute and second.
hristost
force-pushed
the
hs/recurrence-rule-fix-weekday-filter
branch
from
006910c to
dd1c6b8
Compare
|
@swift-ci please test |
itingliu
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When filtering by weekdays, we match the dates against a set of date components. These components happened to contain the hour, minute and second components from the anchor date, so filtering would undo previous expansions by hour, minute and second.