RecurrenceRule: Respect leap months #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes a fix to `Calendar.RecurrenceRule` with regards to leap months and adds a few tests to verify correctness. When constructing the base sequence, we include `isLeapMonth` of the start date in the date components. Before, start dates falling on a leap month would have been treated the same as dates which do fall on the non-leap month before.
Contributor
Author
|
@swift-ci please run |
hristost
commented
Oct 24, 2024
| Date(timeIntervalSince1970: 1730712000.0), // 2024-11-04T01:20:00-0800 | ||
| ] | ||
| XCTAssertEqual(results, expectedResults) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
some unrelated whitespace changes here, these would have happened in one commit or another.
Contributor
Author
|
@swift-ci please test |
1 similar comment
Contributor
Author
|
@swift-ci please test |
itingliu
approved these changes
Oct 31, 2024
cthielen
pushed a commit
to cthielen/swift-foundation
that referenced
this pull request
Nov 8, 2024
This change makes a fix to `Calendar.RecurrenceRule` with regards to leap months and adds a few tests to verify correctness. When constructing the base sequence, we include `isLeapMonth` of the start date in the date components. Before, start dates falling on a leap month would have been treated the same as dates which do fall on the non-leap month before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes a fix to
Calendar.RecurrenceRulewith regards to leap months and adds a few tests to verify correctness. When constructing the base sequence, we includeisLeapMonthof the start date in the date components. Before, start dates falling on a leap month would have been treated the same as dates which do fall on the non-leap month before.