Skip to content

Fix empty.split w/ empty separator #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2022
Merged

Fix empty.split w/ empty separator #353

merged 1 commit into from
Apr 26, 2022

Conversation

natecook1000
Copy link
Member

This change corrects the behavior here:

"".split(separator: "", omittingEmptySubsequences: false)
// [""]  --  was ["", ""]

"".split(separator: "")
// []

@natecook1000
Copy link
Member Author

@swift-ci Please test

milseman
milseman approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natecook1000 natecook1000 merged commit 9ff87db into swiftlang:main Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milseman milseman milseman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natecook1000 @milseman