Fix error in displaySize #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kubamracek can you take this one? |
|
Yup. I can confirm that the build failure is currently present, and that it gets resolved with this PR. |
kubamracek
approved these changes
Dec 18, 2024
|
...and as this example is using Mach-O files, we can't exercise the build in CI currently. |
trundlebits
pushed a commit
to trundlebits/swift-embedded-examples
that referenced
this pull request
Jul 18, 2025
HAL.swift and Board.swift had different names for display width and display height. This change renames vars in Board.swift to have the same names as in HAL.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HAL.swiftandBoard.swifthad different names for display width and display height.This change renames vars in Board.swift to have the same names as in
HAL.swift