Skip to content

Unlock -profile-generate for WebAssembly targets #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Unlock -profile-generate for WebAssembly targets #1712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Sources/SwiftDriver/Jobs/WebAssemblyToolchain+LinkerSupport.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,11 @@ extension WebAssemblyToolchain {
throw Error.sanitizersUnsupportedForTarget(targetTriple.triple)
}

guard !parsedOptions.hasArgument(.profileGenerate) else {
throw Error.profilingUnsupportedForTarget(targetTriple.triple)
if parsedOptions.hasArgument(.profileGenerate) {
let libProfile = VirtualPath.lookup(targetInfo.runtimeResourcePath.path)
.appending(components: "clang", "lib", targetTriple.osName,
"libclang_rt.profile-\(targetTriple.archName).a")
commandLine.appendPath(libProfile)
}

if let lto = lto {
Expand Down
21 changes: 21 additions & 0 deletions Tests/SwiftDriverTests/SwiftDriverTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4463,6 +4463,27 @@ final class SwiftDriverTests: XCTestCase {
}
#endif

// -profile-generate should add libclang_rt.profile for WebAssembly targets
try withTemporaryDirectory { resourceDir in
try localFileSystem.writeFileContents(resourceDir.appending(components: "wasi", "static-executable-args.lnk")) {
$0.send("garbage")
}

for triple in ["wasm32-unknown-wasi", "wasm32-unknown-wasip1-threads"] {
var driver = try Driver(args: [
"swiftc", "-profile-generate", "-target", triple, "test.swift",
"-resource-dir", resourceDir.pathString
])
let plannedJobs = try driver.planBuild().removingAutolinkExtractJobs()

XCTAssertEqual(plannedJobs.count, 2)
XCTAssertEqual(plannedJobs[0].kind, .compile)

XCTAssertEqual(plannedJobs[1].kind, .link)
XCTAssert(plannedJobs[1].commandLine.containsPathWithBasename("libclang_rt.profile-wasm32.a"))
}
}

for explicitUseLd in [true, false] {
var args = ["swiftc", "-profile-generate", "-target", "x86_64-unknown-windows-msvc", "test.swift"]
if explicitUseLd {
Expand Down