[Static SDK] Improve version number/tag extraction. #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are multiple tags on a revision, `git describe` returns the first tag it finds, but we actually don't want that; we want the tag that represents the highest version number. rdar://161117117
shahmishal
approved these changes
Sep 24, 2025
justice-adams-apple
added a commit
to justice-adams-apple/swift-docker
that referenced
this pull request
Oct 2, 2025
shahmishal
pushed a commit
that referenced
this pull request
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are multiple tags on a revision,
git describereturns the first tag it finds, but we actually don't want that; we want the tag that represents the highest version number.rdar://161117117