Skip to content

Highlight declaration differences in overloaded symbol groups #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2024
Merged

Highlight declaration differences in overloaded symbol groups #967

merged 1 commit into from
Jun 28, 2024

Conversation

QuietMisdreavus
Copy link
Contributor

  • Explanation: Calculates the common elements of overload groups and emits a new Render JSON field to note the unique elements in each overload.
  • Scope: UX enhancement for an experimental feature
  • Issue: rdar://116409531
  • Original PR: Highlight declaration differences in overloaded symbol groups #928
  • Risk: Low. This only affects an experimental feature, and only calculates new data without providing a significant change in functionality.
  • Testing: Extensive manual testing, as well as some new automated tests to verify the intended behavior.
  • Reviewer: @d-ronnqvist, @patshaughnessy

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@QuietMisdreavus QuietMisdreavus merged commit d8f7024 into swiftlang:release/6.0 Jun 28, 2024
2 checks passed
@QuietMisdreavus QuietMisdreavus deleted the 6.0/diff-overloads branch June 28, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franklinsch franklinsch franklinsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuietMisdreavus @franklinsch