Make build-script-helper.py use python3 #956
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By aiming to update the Node version to 22.17.0 on Swift Docker for Swift DocC Render [1], we need to specify the version 3 of python, otherwise it will try to use python 2 which it's not available in Node 22. [1] swiftlang/swift-docker#487
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
Removed from __future__ import print_function on line 16, which is not needed in Python 3 since print() is already a function by default.
Updated the node version check to properly handle the fact that subprocess.check_output() returns bytes in Python 3, not strings. Added code to decode bytes to UTF-8 string and strip whitespace before checking the version.
|
@swift-ci test |
mportiz08
reviewed
Jul 28, 2025
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/env python | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
Does this script run in the CI tests for pull requests?
(Just making sure so we can ensure that whatever tool using this script actually does have python 3 installed and there are no syntax issues with this script when running with 3 vs 2.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #156708326, if applicable:
Summary
By aiming to update the Node version to 22.17.0 on Swift Docker for Swift DocC Render [1], we need to specify version 3 of python, otherwise it will try to use python 2 which it's not available in Node 22.
[1] swiftlang/swift-docker#487
Dependencies
This change unblocks this PR in Swift Docker: swiftlang/swift-docker#487
Testing
Steps:
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded