Skip to content

[6.0] Highlight unique components of overloaded declarations #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2024
Merged

[6.0] Highlight unique components of overloaded declarations #849

merged 1 commit into from
Jun 4, 2024

Conversation

mportiz08
Copy link
Contributor

  • Explanation: Updates UI to highlight differing parts of declarations
  • Scope: Impacts pages for overloaded symbols built with the --enable-experimental-overloaded-symbol-presentation DocC compiler flag
  • Issue: rdar://117503463
  • Risk: Low, focused changes to render new declaration token
  • Testing: Added/updated unit tests, manually verified that overloaded symbols render with expected declaration highlights
  • Reviewer: @marinaaisa
  • Original PR: Highlight unique components of overloaded declarations #841

\cc @QuietMisdreavus

@mportiz08 @QuietMisdreavus
Highlight unique components of overloaded declarations (swiftlang#841)
320c351 
Resolves: rdar://128997251

Co-authored-by: Vera Mitchell <[email protected]>
@mportiz08 mportiz08 requested review from Teapane and franklinsch June 3, 2024 23:14
@mportiz08
Copy link
Contributor Author

@swift-ci test

@marinaaisa marinaaisa merged commit e13b1bc into swiftlang:release/6.0 Jun 4, 2024
@mportiz08 mportiz08 deleted the 6.0/highlight-unique-components-of-overloaded-declarations branch June 4, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Teapane Teapane Teapane approved these changes

@franklinsch franklinsch Awaiting requested review from franklinsch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mportiz08 @Teapane @marinaaisa