Guard parse_version #498
Merged
Guard parse_version #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most recent versions of `parse_version` throw an exception if the version is empty. The version passed in is only set on Darwin (call to `mac_ver()`, so it's causing test failures on newer versions of Linux since the test suite can't even start. Now, the only reason for the version parse is because the tests are looking at whether or not concurrency is available on the OS. This is only a limitation if we're working with Darwin. Swift 5.10 on Windows and Linux always have a Swift 5.10 concurrency runtime, so we don't even need to check for a version. rdar://128502662 (cherry picked from commit 65e6ecd)
Member
Author
|
@swift-ci please test |
briancroom
approved these changes
Jun 26, 2024
stmontgomery
approved these changes
Jul 3, 2024
Member
Author
|
@swift-ci please test |
Member
Author
|
@swift-ci please test Linux |
Member
Author
|
swiftlang/swift-foundation#885 |
Contributor
|
@swift-ci test |
Contributor
|
@etcwilde Do you still want to merge this change? |
Member
Author
|
Yeah, we'll need it eventually when working with newer python versions. I'm starting to think maybe my change did break something, but I haven't had a chance to figure out why. |
Member
|
@swift-ci test |
Member
Author
|
@swift-ci please test |
shahmishal
approved these changes
Sep 13, 2024
Member
Author
|
@swift-ci please test |
Member
Author
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main cherry-pick of #489.
The most recent versions of
parse_versionthrow an exception if the version is empty. The version passed in is only set on Darwin (call tomac_ver(), so it's causing test failures on newer versions of Linux since the test suite can't even start.Now, the only reason for the version parse is because the tests are looking at whether or not concurrency is available on the OS. This is only a limitation if we're working with Darwin. Swift 5.10 on Windows and Linux always have a Swift 5.10 concurrency runtime, so we don't even need to check for a version.
rdar://128502662
(cherry picked from commit 65e6ecd)