Skip to content

Add a missing semicolon in src/io.c. #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

allevato
Copy link
Member

I'm really confused about why this doesn't fail to compile on swift-ci; I would expect that #else branch to be tested when building for Linux. When I recently updated our internal copy of the Linux toolchain past #805, it failed:

src/io.c:2377:59: error: expected ';' after expression
 2377 |                         op->buf = aligned_alloc((size_t)PAGE_SIZE, op->buf_siz)
      |                                                                                ^
      |                                                                                ;

@allevato
Copy link
Member Author

@swift-ci please test

@allevato
Copy link
Member Author

@compnerd I don't have write access on this repo; can you please take a look? 🙂

@compnerd compnerd merged commit 1897407 into swiftlang:main Mar 28, 2024
2 checks passed
@allevato allevato deleted the patch-1 branch March 28, 2024 18:40
@finagolfin
Copy link
Member

This will need to be fixed in the 6.0 branch also.

@allevato
Copy link
Member Author

allevato commented Apr 1, 2024

This will need to be fixed in the 6.0 branch also.

#824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants