Fix possible crash in _dispatch_wait_for_enqueuer on Android armeabi-v7a #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@etcwilde, would you review? |
rokhinip
requested changes
Dec 10, 2021
The WFE instruction can sometimes cause a SIGILL on these devices, so we use YIELD instead. https://bugs.swift.org/browse/SR-15166
triplef
force-pushed
the
fix-dispatch_wait_for_enqueuer
branch
from
6ffcc3a to
6f715aa
Compare
|
@swift-ci please test |
rokhinip
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by
__builtin_arm_wfe()sometimes causing aSIGILL.For details please see https://bugs.swift.org/browse/SR-15166.