Skip to content

Remove final from vars in error related protocol extensions #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2017
Merged

Remove final from vars in error related protocol extensions #917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Foundation/NSError.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,8 +377,8 @@ extension __BridgedNSError where Self: RawRepresentable, Self.RawValue: SignedIn
}

public extension __BridgedNSError where Self: RawRepresentable, Self.RawValue: SignedInteger {
public final var _domain: String { return Self._nsErrorDomain }
public final var _code: Int { return Int(rawValue.toIntMax()) }
public var _domain: String { return Self._nsErrorDomain }
public var _code: Int { return Int(rawValue.toIntMax()) }

public init?(rawValue: RawValue) {
self = unsafeBitCast(rawValue, to: Self.self)
Expand All @@ -392,7 +392,7 @@ public extension __BridgedNSError where Self: RawRepresentable, Self.RawValue: S
self.init(rawValue: RawValue(IntMax(_bridgedNSError.code)))
}

public final var hashValue: Int { return _code }
public var hashValue: Int { return _code }
}

// Allow two bridged NSError types to be compared.
Expand All @@ -403,8 +403,8 @@ extension __BridgedNSError where Self: RawRepresentable, Self.RawValue: Unsigned
}

public extension __BridgedNSError where Self: RawRepresentable, Self.RawValue: UnsignedInteger {
public final var _domain: String { return Self._nsErrorDomain }
public final var _code: Int {
public var _domain: String { return Self._nsErrorDomain }
public var _code: Int {
return Int(bitPattern: UInt(rawValue.toUIntMax()))
}

Expand All @@ -420,7 +420,7 @@ public extension __BridgedNSError where Self: RawRepresentable, Self.RawValue: U
self.init(rawValue: RawValue(UIntMax(UInt(_bridgedNSError.code))))
}

public final var hashValue: Int { return _code }
public var hashValue: Int { return _code }
}

/// Describes a raw representable type that is bridged to a particular
Expand Down