chore: restrict GitHub workflow permissions - future-proof #5276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Melissa Kilby <[email protected]>
Contributor
Author
|
May I kindly check in on the status of this PR? Thank you. |
shahmishal
reviewed
Oct 17, 2025
| name: Create PR to merge release branch into the main branch | ||
| # At the end of a release cycle, we may want to automatically include all changes to release branches on the main branch to avoid the need for cherry-picking changes back to release branches | ||
| # This workflow can be disabled earlier in the release cycle in the GitHub UI as described in https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/disabling-and-enabling-a-workflow | ||
| permissions: |
Member
There was a problem hiding this comment.
Same question I asked in different PR in swift-format.
How does this change impact the permissions set inside jobs.
permissions:
contents: write
pull-requests: write
Contributor
Author
There was a problem hiding this comment.
See answer in the swift-format PR: swiftlang/swift-format#1073 (comment)
shahmishal
approved these changes
Oct 20, 2025
Contributor
Author
|
Thanks for approving the PR, what are the next steps? Thanks. |
jmschonfeld
approved these changes
Oct 27, 2025
Contributor
|
@swift-ci please test |
Contributor
Author
|
Hmm the Windows CI still appears to block merging ... any ideas on how to unblock this PR? Thanks a bunch! |
Contributor
|
@swift-ci please test Windows platform |
Contributor
Author
|
@jmschonfeld and @shahmishal CI is cleared - may I kindly check in on the status of this PR? Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See swiftlang/github-workflows#167 for additional context
This approach aligns with security best practices, as detailed in the following documentation: